Signal-Android icon indicating copy to clipboard operation
Signal-Android copied to clipboard

Fixes #13936 - Finish StoryActivity if Story was already deleted

Open Sagar0-0 opened this issue 10 months ago • 0 comments

Closes #13936

First time contributor checklist

Contributor checklist

  • Device A, Android X.Y.Z
  • Device B, Android Z.Y
  • Virtual device W, Android Y.Y.Z
  • [x] My contribution is fully baked and ready to be merged as is
  • [x] I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

Fixes: Closes the StoryActivty if onQuoteClick has a deleted message's ID.

Improvements:

  1. Start this StoryActivity for result, and if the result from StoryViewerFragment says that the story message is deleted, then after receiving that result in ChaFragment, update that paticular message's state. Should I use onActivityResult? or launcher? Is it fine to update the message state from this callback?

  2. Add a callback listening to deletion of story.

Sagar0-0 avatar Jan 24 '25 07:01 Sagar0-0