Signal-Android icon indicating copy to clipboard operation
Signal-Android copied to clipboard

Support Video Mode for CameraXFragment

Open Sagar0-0 opened this issue 10 months ago • 2 comments

First time contributor checklist

Contributor checklist

  • Device A, Android X.Y.Z
  • Device B, Android Z.Y
  • Virtual device W, Android Y.Y.Z
  • [x] My contribution is fully baked and ready to be merged as is
  • [x] I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

  1. The new MediaMode (currently textStoryToggleMode) has 3 Mode { VIDEO, CAMERA, TEXT }.
  2. The HugCommand has a new GoToVideo command.
  3. To update the State properly, All GoToX HudCommands are handled in the MediaSelectionActivity.
  4. A new VideoCameraButtonView is created to handle video button view independently

HELP:

  1. For Camera1Fragment, I am not sure what is the recommended way to hide the video tab, simply put it in an if statement.

Problem/Bugs: After testing, I have encountered further issues:

  1. User can press on the gallery while recording.
  2. User can change the MediaMode while recording.
  3. User can press back while recording. These issues are fixed in my last PR #13933
  4. The CameraFragment is destroyed and recreated every time when we come back from TextStoryFragment, this can be prevented. (This already existed but is not introduced in this change).

Improvements:

  1. VideoCameraButtonView can be improved, open for suggestions.

Sagar0-0 avatar Jan 23 '25 16:01 Sagar0-0

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 25 '25 22:03 stale[bot]

unstale

Sagar0-0 avatar Mar 26 '25 16:03 Sagar0-0

This issue has been closed due to inactivity.

stale[bot] avatar Apr 03 '25 02:04 stale[bot]