Signal-Android
Signal-Android copied to clipboard
Support Video Mode for CameraXFragment
First time contributor checklist
- [x] I have read how to contribute to this project
- [x] I have signed the Contributor License Agreement
Contributor checklist
- [x] I am following the Code Style Guidelines
- [x] I have tested my contribution on these devices:
- Device A, Android X.Y.Z
- Device B, Android Z.Y
- Virtual device W, Android Y.Y.Z
- [x] My contribution is fully baked and ready to be merged as is
- [x] I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the
Fixes #1234syntax
Description
- The new MediaMode (currently textStoryToggleMode) has 3 Mode { VIDEO, CAMERA, TEXT }.
- The HugCommand has a new GoToVideo command.
- To update the State properly, All GoToX HudCommands are handled in the MediaSelectionActivity.
- A new VideoCameraButtonView is created to handle video button view independently
HELP:
- For Camera1Fragment, I am not sure what is the recommended way to hide the video tab, simply put it in an if statement.
Problem/Bugs: After testing, I have encountered further issues:
- User can press on the gallery while recording.
- User can change the MediaMode while recording.
- User can press back while recording. These issues are fixed in my last PR #13933
- The CameraFragment is destroyed and recreated every time when we come back from TextStoryFragment, this can be prevented. (This already existed but is not introduced in this change).
Improvements:
- VideoCameraButtonView can be improved, open for suggestions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
unstale
This issue has been closed due to inactivity.