Signal-Android icon indicating copy to clipboard operation
Signal-Android copied to clipboard

OKHTTP3 library is out of date.

Open epachamo opened this issue 10 months ago • 1 comments

  • [x ] I have searched open and closed issues for duplicates
  • [x ] I am submitting a bug report for existing functionality that does not work as intended
  • [x ] I have read https://github.com/signalapp/Signal-Android/wiki/Submitting-useful-bug-reports
  • [x ] This isn't a feature request or a discussion topic

Bug description

The current version of OKHttp is 3. This should be upgraded to OKHttp 4, as version 3 hasn't received an update in almost 4 years now.

Upgrading is easy, I forked signal, made the mostly syntactic changes myself, ran the tests successfully. Upgrade instructions are given here by the library maintainers:

https://square.github.io/okhttp/changelogs/upgrading_to_okhttp_4/

epachamo avatar Mar 29 '24 14:03 epachamo

We had tried to perform the 3 -> 4 upgrade back in Signal 6.32, but it caused deadlocks inside our CI pipeline. We hope to revisit it eventually.

nicholas-signal avatar Mar 29 '24 16:03 nicholas-signal

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 29 '24 00:05 stale[bot]