Signal-Android icon indicating copy to clipboard operation
Signal-Android copied to clipboard

present perfect for some English strings

Open lpirl opened this issue 1 year ago • 4 comments

What would you think of some more present perfect for some English strings where the focus is on the current situation, rather than the past? Simple past triggered me especially in "message was deleted" because I suppose Signal is actually trying to tell users that the message is deleted.

Feel free to add comments in the review where my changes are inappropriate.

If this PR is welcome, I'd port it to iOS and desktop.

lpirl avatar Feb 14 '24 11:02 lpirl

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 14 '24 13:04 stale[bot]

I am happy to apply some changes, if desired. :)

lpirl avatar Apr 14 '24 13:04 lpirl

Hi! I'll bring this up with our localisation manager.

alex-signal avatar Apr 15 '24 12:04 alex-signal

That is great, thank you @alexr-signal .

lpirl avatar Apr 15 '24 13:04 lpirl

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 15 '24 01:06 stale[bot]

still waiting for response from localisation manager, happy if this would not be closed

lpirl avatar Jun 15 '24 09:06 lpirl

Hi, I think we'll be keeping the strings as they are, but thank you!

greyson-signal avatar Jun 17 '24 13:06 greyson-signal

Sad, because IMHO, present perfect would be more correct in some cases. Anyway, thanks a lot for considering.

lpirl avatar Jun 17 '24 13:06 lpirl