present perfect for some English strings
What would you think of some more present perfect for some English strings where the focus is on the current situation, rather than the past? Simple past triggered me especially in "message was deleted" because I suppose Signal is actually trying to tell users that the message is deleted.
Feel free to add comments in the review where my changes are inappropriate.
If this PR is welcome, I'd port it to iOS and desktop.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
I am happy to apply some changes, if desired. :)
Hi! I'll bring this up with our localisation manager.
That is great, thank you @alexr-signal .
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
still waiting for response from localisation manager, happy if this would not be closed
Hi, I think we'll be keeping the strings as they are, but thank you!
Sad, because IMHO, present perfect would be more correct in some cases. Anyway, thanks a lot for considering.