Signal-Android icon indicating copy to clipboard operation
Signal-Android copied to clipboard

"spoiler" messages appear in clear in notification when attached with a picture

Open ft-fk opened this issue 1 year ago • 3 comments

  • [ x] I have searched open and closed issues for duplicates
  • [x ] I am submitting a bug report for existing functionality that does not work as intended
  • [x ] I have read https://github.com/signalapp/Signal-Android/wiki/Submitting-useful-bug-reports
  • [x ] This isn't a feature request or a discussion topic

Bug description

"spoiler" messages arrive to recipient in clear in notification when attached with an picture. Spoiler message (without picture) are normally replaced by block characters. Here the word(s) appear in full.

Steps to reproduce

  • write a message and apply spoiler to the text
  • attach a picture to the message, send it
  • recipient : have the message in clear in their notification bubble

Actual result: recipient : have the message in clear in their notification bubble Expected result: recipients : have the spoiler text replaced with blocks that masks the text

Device info

recipient is Device: samsung s10e Android version: 12 Signal version: 6.41.2

Link to debug log

ft-fk avatar Jan 21 '24 10:01 ft-fk

Hey @ft-fk , I would like to work on this issue if still open. Please assign this to me.

Tejas-67 avatar Jan 25 '24 06:01 Tejas-67

Will be fixed in 6.46

@Tejas-67 we don't really assign GH issues, if you want to work on one, just have at it and open a PR. In this case, we had already planned to do it but not always.

cody-signal avatar Jan 29 '24 21:01 cody-signal

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 30 '24 18:03 stale[bot]