Signal-Android icon indicating copy to clipboard operation
Signal-Android copied to clipboard

re-add system contact shortcut

Open fm-sys opened this issue 1 year ago • 2 comments

Contributor checklist

  • Emulator, Android API 33
  • [x] My contribution is fully baked and ready to be merged as is
  • [x] I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

Around half a year ago when the conversation fragment was largely rewritten, the long click shortcut to access the system contact was (accidentally?) removed. I thought I would get used to it, but I'm still missing that option... I would really appreciate it if it was readded.

With this PR merged, long-clicking the contact name in the conversation action bar will open the system contact if available.

fm-sys avatar Jan 20 '24 16:01 fm-sys

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 22 '24 01:03 stale[bot]

Hey @cody-signal @greyson-signal,

Could you be so kind to at least drop off a short message, no matter whether or not this PR gets accepted... Thank you!

Best regards Florian

fm-sys avatar Mar 22 '24 11:03 fm-sys

Hi! I'll run this by the team and make sure we want this functionality reintroduced.

alex-signal avatar May 09 '24 12:05 alex-signal

Feature is available in Signal meanwhile, so I think we can close this PR. Thanks for taking it in!

fm-sys avatar Jun 28 '24 23:06 fm-sys