signalapp
Member count in new group creation is horribly broken
- [x] I have searched open and closed issues for duplicates
- [x] I am submitting a bug report for existing functionality that does not work as intended
- [x] I have read https://github.com/signalapp/Signal-Android/wiki/Submitting-useful-bug-reports
- [x] This isn't a feature request or a discussion topic
Bug description
When selecting the members for a new group, the counter shows the wrong number.
Steps to reproduce
- Create a new group
- Select contacts to add to new group
- Deselect contacts
- Observe header
Actual result: After selecting one contact, the header does not change. After selecting a second contact, the header now says "1 member". Deselecting one of those contacts will result in the header now saying "2 members", but only one is selected. Deselecting all contacts leaves "1 member" in the header. Expected result: The correct number of members is shown.
Screenshots
Device info
Device: Pixel 7 Pro Android version: 13 Signal version: 6.34.5
Link to debug log
https://debuglogs.org/android/6.34.5/ac507381b5ab10c4f7c0ae6ee834d37c86b42f2f832dd0521932a8ada33195e1
I'd like to work on this issue. It seems like an interesting problem to tackle. Could you please assign this issue to me?
I've encountered the exact same thing when creating a group right now. The same signal version as above ^
@lakshaybomotra feel free to open a PR
i opened a PR please check, its my first contribution sorry if i made a mistake.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
The exact behavior has changed and the counter no longer shows the wrong number, but there are still some issues.
When you select the first member, the header still says "Select Members" and changes to say "2 members" once the second member is selected. If you deselect the second member, the header now says "1 member". If you deselect the one remaining member, it changes to "0 members", but selecting one contact again changes the header back to "Select Members".
This is inconsistent and confusing.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
When you select the first member, the header still says "Select Members" and changes to say "2 members" once the second member is selected. If you deselect the second member, the header now says "1 member". If you deselect the one remaining member, it changes to "0 members", but selecting one contact again changes the header back to "Select Members".
This is still the current behavior.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.