Signal-Android icon indicating copy to clipboard operation
Signal-Android copied to clipboard

Fix Meteor0id enhance ringing sounds

Open Sgn-32 opened this issue 3 years ago • 26 comments

Contributor checklist

  • Moto X Play, Android 7.1.1
  • [X] My contribution is fully baked and ready to be merged as is

Description

PR with @Meteor0id improved sound files for outgoing and busy calling sound. Learn more: https://github.com/signalapp/Signal-Android/pull/8948

Sgn-32 avatar Aug 12 '22 19:08 Sgn-32

There are also two other files which could potentially be added to this PR but those would require some code changes:

  1. a sound for the connecting / establishing phase of a call. This one sounds very similar to outing, with only a minor difference in the time between each ring sound. The goal is to make the difference between connecting and actually calling audible to people who cannot easily read their screen (accessibility).
  2. A call ended sound. Don't you just hate when someone hangs up and you have to check your screen to make sure the call actually ended? It's just a single low tone beep.

Would be nice to add those too but if you end up just merging outgoing and busty sounds that's still a nice enhancement.

Meteor0id avatar Aug 19 '22 17:08 Meteor0id

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 18 '22 17:10 stale[bot]

This issue has been automatically marked as stale...

This isn't an issue, it's a PR. I hope design prefers a clear ringtone and not noisy ones.

Sgn-32 avatar Oct 19 '22 18:10 Sgn-32

ha ha... The bot got his wires crossed 🤣

clauz9 avatar Oct 20 '22 05:10 clauz9

I've brought this up to design multiple times, it's in their court.

cody-signal avatar Oct 20 '22 15:10 cody-signal

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 19 '22 20:12 stale[bot]

Still no news from Design? Since it's Christmas, I hope Design gets a good music system as a gift. So they no longer need to use a gramophone for sound tests.

Sgn-32 avatar Dec 21 '22 18:12 Sgn-32

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 26 '23 23:03 stale[bot]

We seem to be getting a calls overhaul but the sound hasn't been touched upon yet.. I really hope they work on it since it's a stupidly simple task compared to all the awesome work they've done for calls in the current beta.

UnderscoreX5 avatar Mar 28 '23 17:03 UnderscoreX5

Seen this feature request in the forum:

https://community.signalusers.org/t/the-dialing-sounds-are-not-the-same-between-android-and-desktop-versions/53153

How about the ringing sound of Signal Desktop?

https://github.com/signalapp/Signal-Desktop/blob/main/sounds/ringtone_minimal.ogg

Or sounds from Signal iOS?

https://github.com/signalapp/Signal-iOS/blob/main/Signal/AudioFiles/ringback_tone_ansi.caf https://github.com/signalapp/Signal-iOS/blob/main/Signal/AudioFiles/busy_tone_ansi.caf

Sgn-32 avatar May 05 '23 18:05 Sgn-32

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 09 '23 08:07 stale[bot]

Such a simple fix, lets not waste it by ignoring it

Meteor0id avatar Jul 09 '23 11:07 Meteor0id

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 09 '23 05:09 stale[bot]

A comment for stalebot

Sgn-32 avatar Sep 09 '23 11:09 Sgn-32

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 09 '23 00:11 stale[bot]

.

Meteor0id avatar Nov 09 '23 00:11 Meteor0id

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 08 '24 16:01 stale[bot]

Kick

Meteor0id avatar Jan 08 '24 16:01 Meteor0id

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 08 '24 21:03 stale[bot]

Signals noicy ribgtones still hurt my ears. I love the authentic old sound but the noice shouldn't be part if it

Meteor0id avatar Mar 09 '24 02:03 Meteor0id

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 08 '24 05:05 stale[bot]

Why not test it in the next beta and get feedback from the beta testers?

Sgn-32 avatar May 12 '24 06:05 Sgn-32

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 13 '24 07:07 stale[bot]

Oh no, stale-bot.

Sgn-32 avatar Jul 14 '24 08:07 Sgn-32

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 13 '24 03:09 stale[bot]

For anyone curious, this is still true:

I've brought this up to design multiple times, it's in their court.

cody-signal avatar Sep 13 '24 14:09 cody-signal

This issue has been closed due to inactivity.

stale[bot] avatar Sep 20 '24 23:09 stale[bot]

Stale-bot! Why closed? A dev has commented after marking as "wontfix". Shouldn't comments from devs remove the "wontfix"-label?

Sgn-32 avatar Oct 04 '24 09:10 Sgn-32