replication-manager icon indicating copy to clipboard operation
replication-manager copied to clipboard

The force option has no effect.

Open nyxneuf opened this issue 1 year ago • 2 comments

SRM : v2.2.25 MariaDB -10.6 M-S

force-slave-readonly = true

The above options do not work.

and

https://github.com/signal18/replication-manager/blob/develop/etc/cluster.d/cluster1.toml https://github.com/signal18/replication-manager/blob/develop/config/config.go

force-slave-failover-readonly-state = false

The above option is not in config.go

nyxneuf avatar Jul 14 '22 04:07 nyxneuf

https://github.com/signal18/replication-manager/compare/v2.2.20...v2.2.21

https://github.com/signal18/replication-manager/commit/0b9f16005390dd905470bcaf98b5a91c12a290fc#diff-5bb4c626ee0cfad5a85fa30ec20e412f89ed0abf03e950a7511b28b8fdd89c80

[srv_chk.go] if server.ClusterGroup.Conf.ForceSlaveReadOnly && sl.ReadOnly == "OFF" && !server.ClusterGroup.IsInIgnoredReadonly(server) && !server.ClusterGroup.IsMultiMaster() {

[cluster_has.go] func (cluster *Cluster) IsMultiMaster() bool { if cluster.GetTopology() != topoMultiMasterWsrep || cluster.GetTopology() != topoMultiMaster || cluster.GetTopology() != topoMultiMasterRing { return true } return false }

With the above code change, it doesn't work.

if cluster.GetTopology() == topoMultiMasterWsrep || cluster.GetTopology() == topoMultiMaster || cluster.GetTopology() == topoMultiMasterRing

Shouldn't this code be changed? please check.

nyxneuf avatar Jul 15 '22 01:07 nyxneuf

Agree look like super wrong lucky that function only used in one place

svaroqui avatar Sep 15 '23 06:09 svaroqui