sigmike
failing tests in master
i added a note to the README that phantomjs is required for some cucumber tests - still there are a number of them failing - i have not yet investigated these so perhaps my configuration is incorrect but even so then this is notable
Failing Scenarios:
cucumber features/distribute_to_commits.feature:57 # Scenario: Distribute to commits not linked to a GitHub account
cucumber features/distribute_to_user_identifier.feature:4 # Scenario:
cucumber features/distribution.feature:179 # Scenario: Send to an unknown email address
cucumber features/distribution.feature:238 # Scenario: Send to an known email address who has no confirmation token
cucumber features/distribution.feature:317 # Scenario: Send to a known email address
all activesupport tests are failing - i started fixing the superficial ones but there are deeper issues - my guess is that these tests were built by scaffolding and never actually used - if this is the case and because the rspec gem already is a requirement but no rspec tests are present - i recommend that at least the standard rspec test suite be generated and made to pass - below are the first two issues one will encounter running these tests but again i have these stashed but did not bother to commit them as it is questionable whether or not the activesupport test suite is worth rescuing
BUG: the migration:
db/migrate/20140530132209_rename_sendmany_to_distribution.rb
renamed the 'sendmanies' table to 'distributions' but the test fixture
test/fixtures/sendmanies.yml
was not renamed - this causes all activesupport tests to fail
SOLUTION: rename test/fixtures/sendmanies.yml to test/fixtures/distributions.yml
mv test/fixtures/sendmanies.yml test/fixtures/distributions.yml
BUG: the migration:
db/migrate/20140714074128_add_identifier_to_user.rb
constrains the :identifier field to be unique - and:
db/migrate/20131019133109_devise_create_users.rb
constrains the :email field to be unique - this causes all activesupport tests to fail
SOLUTION: define unique emails and identifiers in test/fixtures/users.yml
one:
email: [email protected]
identifier: aString
two:
email: [email protected]
identifier: anotherString
the Developer README refers to currently non-existing rspec tests - this should be updated when this issue is resolved if the activesupport tests are prefered over rspec