Ian Stapleton Cordasco
Ian Stapleton Cordasco
> I don't think that's a good idea, you would get different objects when importing from the new vs the old location. You're correct but I'm having trouble imagining a...
It seems you have a clear understanding of the problem. I'd happily merge a PR that solves the issue here.
I don't see much in https://github.com/kennethreitz/requests/compare/v2.13.0...v2.14.2 that would cause this, realistically speaking. @Lukasa do you have any ideas?
Sounds like this happens on deploy to GAE. @forsberg is there any chance you can reproduce this locally?
> I will see what I can do, but it'll probably take a few days. As long as you don't forget about us, feel free to take all the time...
> The same thing happens with requests versions 2.10.0, 2.13.0 and 2.14.2, those being the only versions I explicitly tested. That's surprising. This adapter was written and explicitly tested against...
@forsberg that seems unlikely to be related to this. That was related to the unvendoring of dependencies that happened a few weeks ago (prior to your opening this issue).
I'm open to this too. I will just have some opinions about how it's added so pieces of it can be more reusable for others (if that makes any sense)....
@rashley-iqt a pull request might be a better place to discuss it but sure.
The headers are not actually fully decoded which is exactly why they're bytes. We don't do any post processing (i.e., what would be required to handle RFC 2231 headers).