sigmah icon indicating copy to clipboard operation
sigmah copied to clipboard

Published 20 hours ago • verified publisher icon sigmah-dev

Convert importation framework "successful update" info popup into notification Description

Open manishvishnoi2 opened this issue 8 years ago • 5 comments

Fixes 0000843.

manishvishnoi2 avatar Mar 14 '16 14:03 manishvishnoi2

Weren't able to apply/run this patch yet. But, it looks good to me. I think build failed because of other problem.

sherzodmuratov avatar Mar 15 '16 15:03 sherzodmuratov

hello @sherzodmuratov What problem is occuring.Is it because of travis CI.Are you able to check/run other two of my PR.

manishvishnoi2 avatar Mar 15 '16 17:03 manishvishnoi2

@sherzodmuratov is right, travis is considering the build as broken but it's not a problem in @manishvishnoi2's code, it's a problem on the sigmah-dev master branch. We are looking forward to fix this issue before looking at the pull-requests.

ghost avatar Mar 15 '16 17:03 ghost

@numero-six ok.

manishvishnoi2 avatar Mar 15 '16 18:03 manishvishnoi2

Well, Manish's code is straightforward. It seems OK to me, @osarrat can you checkout the manish branch and check that this is OK functionally?

You can use git instructions, see "command-line instructions" below, "Step 1: From your project repository, check out a new branch and test the changes.".

ghost avatar Mar 22 '16 16:03 ghost