sigmah icon indicating copy to clipboard operation
sigmah copied to clipboard

[WIP] Advanced calendar component (issue#852)

Open Seal98 opened this issue 7 years ago • 2 comments

First commit of changes for "Add event" calendar view. Added: -new Date field for End event Date, -radio group to select repeat period, -panels to set parameters for monthly and yearly events, -tooltips, -auto added to event description type of event which is selected to be created. For testing purposes: -creation by default 2 events with selected date and date + 1 day. -added hardcoded text in the second Event name for testing purposes.

Some string values in the source code are hardcoded yet.

Seal98 avatar Jun 09 '17 13:06 Seal98

Hi @Seal98 ,

Some feedbacks on your work :

  • good ! you makes small frequent commits, it is a good habit to follow
  • careful : you can see that your pull request is currently breaking both the Travis and Codacy checks. Before continuing your coding, you should read their Details report and fix what must be fixed
  • finally, each commit must have a single different title, read the Contribution rules on that matter :)

Have a nice day !

osarrat avatar Jun 16 '17 12:06 osarrat

Hi @Seal98 ,

A small important feedback : as I told you for your other Pull Request, add a space when typing "issue #824" in your commit title: typed as you did it, it won't be recognized by Mantis .

Good luck for the final stretch !

osarrat avatar Aug 24 '17 08:08 osarrat