IRust icon indicating copy to clipboard operation
IRust copied to clipboard

Do not write options to config by default

Open actuday6418 opened this issue 1 year ago • 2 comments

This is really unusual to a user who

  • Has iRust open in one window
  • Edits config.toml in another window
  • Closes and opens iRust
  • Sees changes to config have reverted

Saving config changes should be an explicit command.

actuday6418 avatar Sep 27 '24 05:09 actuday6418

Thanks for the feedback, that makes sense

fixed in 1.71.24 the new explicit command is save_options

sigmaSd avatar Sep 27 '24 15:09 sigmaSd

I ha to revert this because it interacted poorly with the options loading and the detection of first run of irust, I can it correctly when I have time

sigmaSd avatar Oct 06 '24 13:10 sigmaSd

IRust will now not overwrite the config file if it detect it have external changes

Fixed in https://github.com/sigmaSd/IRust/commit/ebf153af4504a11e3af08d1e2c47809e4bdac778

Available in IRust 1.72.0

sigmaSd avatar Mar 11 '25 04:03 sigmaSd