ytmusicapi icon indicating copy to clipboard operation
ytmusicapi copied to clipboard

get_library_playlists: When limit is None, return them all.

Open Auzzy opened this issue 3 years ago • 8 comments

This PR allows the user to pass a limit of None to get_library_playlists in order to get back all of their playlists.

Addresses #275

Auzzy avatar May 30 '22 20:05 Auzzy

I like this approach because it can be easily adapted for the other endpoints mentioned in #275.

Do you want to tackle the others also in this PR? Should only be a few lines to change in a similar fashion, and the docstring.

sigma67 avatar Jun 01 '22 11:06 sigma67

I like this approach because it can be easily adapted for the other endpoints mentioned in #275.

Do you want to tackle the others also in this PR? Should only be a few lines to change in a similar fashion, and the docstring.

Yeah, I should be able to take care of those sometime in the next few days.

Auzzy avatar Jun 01 '22 11:06 Auzzy

Are you still working on this?

sigma67 avatar Aug 02 '22 11:08 sigma67

@Auzzy Are you still working on this? I'll be glad to take it off your hand

adrinu avatar Aug 25 '22 00:08 adrinu

Feel free to take it over, @Auzzy hasn't been active here for almost 3 months.

I don't think you can collaborate on this PR without their approval, so feel free to pull this and submit your own PR

git checkout -b retrieve-all-playlists master
git pull https://github.com/Auzzy/ytmusicapi.git retrieve-all-playlists

You'll also need to rebase to current master

sigma67 avatar Aug 26 '22 09:08 sigma67

Considering a new release end of September, would be great if you could tackle it by then :) If not I can take over.

sigma67 avatar Sep 02 '22 09:09 sigma67

Considering a new release end of September, would be great if you could tackle it by then :) If not I can take over.

Yep, working on it! Will have it done before the release

adrinu avatar Sep 03 '22 04:09 adrinu

So next week at the latest ;)

sigma67 avatar Sep 23 '22 10:09 sigma67

merged in 1b94985014dc8eb5df4a2de3cdca75c883e0615e

sigma67 avatar Sep 26 '22 12:09 sigma67