jn-npp-plugin icon indicating copy to clipboard operation
jn-npp-plugin copied to clipboard

Make folder of JS part a submodule

Open KOLANICH opened this issue 9 years ago • 8 comments

Move folder with JS part (/deploy/[Notepad++ Directory]/plugins/jN) to separate repo Make it a submodule Merge with https://github.com/KOLANICH/jN-npp-scripts

KOLANICH avatar Aug 05 '15 18:08 KOLANICH

@sieukrem

KOLANICH avatar Jan 04 '17 19:01 KOLANICH

Could you explain the advantage of submodule aproach!?

sieukrem avatar Jan 04 '17 21:01 sieukrem

Now you have a single repo for JS and C++ parts of plugin, but they are relatively standalone: most of users don't need the C++ part of your repo, but everybody needs the JS one, and the JS part is interacting with C++ through API and is not needed in order to build. The advantage of having separate repos for that is that they can be cloned separately, so you can place JS part repo into your npp "plugins/jN/" dir, upgrade with git pull and develop in place. To install it a user just needs to clone it there. Now a user have to clone the whole repo and extract JS part from there. Another solution is to clone my repo ;)

KOLANICH avatar Jan 04 '17 23:01 KOLANICH

@sieukrem

KOLANICH avatar Dec 12 '17 20:12 KOLANICH

:) I would go this way. Can you make a suggestion for corresponding appveyor.yml packaging scripts and dll together from different repositories?

sieukrem avatar Dec 12 '17 20:12 sieukrem

In fact I have never used appveyor, but I guess git submodules should do the work as long as you can trigger submodule update.

KOLANICH avatar Dec 12 '17 20:12 KOLANICH

@sieukrem

KOLANICH avatar Jan 03 '18 09:01 KOLANICH

Not a bad idea with the submodule. If you'll want to go for it, only adding an "install" phase as described in the doc should be enough. The rest of the page should not apply, I suppose, as the repo will probably not be a private one.

AakaFosfor avatar Mar 30 '19 18:03 AakaFosfor