QSyncthingTray icon indicating copy to clipboard operation
QSyncthingTray copied to clipboard

Pausing syncthing using the menu, causes almost 200% cpu usage.

Open vext01 opened this issue 8 years ago • 11 comments

Hi,

Noticed that qsyncthing tray pegs cores when you pause syncthing.

This is version qsyncthingtray-0.5.5rc1 on OpenBSD. Can you repro?

P.S.

qsyncthingtray is an OpenBSD package now, thanks!

http://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/net/qsyncthingtray/

vext01 avatar Nov 23 '16 17:11 vext01

sweet! thanks! 👍

And yeah, technically I dont get 200%, but I do get blocking on the main thread for a while. Does it stay on 200% indefinitely for you?

Either way, this will be fixed as part of https://github.com/sieren/QSyncthingTray/issues/176#issuecomment-262390861 - the process handling isnt in a good state and I need to rewrite it completely and move it out of the Connection Handling. It doesn't belong there and the only reason it actually is, was because I've been a bit lazy when I started QST.

sieren avatar Nov 23 '16 17:11 sieren

Yeah it climbs to near 200 and stays there.

vext01 avatar Nov 23 '16 17:11 vext01

I can confirm buggy behavior on 0.5.5rc1 CPU climbing up when pause is clicked from r-click menu. In my case I observed it climbing up to about 97% cpu usage on a 4 core machine and staying there.

Running OpenBSD -current amd64

mulander avatar Nov 23 '16 17:11 mulander

Ah, bummer. Either way though, this is the next thing I'll be working on. In fact I already started, but it takes a while.

sieren avatar Nov 23 '16 17:11 sieren

If you want to help out, mind checking out this PR https://github.com/sieren/QSyncthingTray/pull/184 and see if it's still an issue?

sieren avatar Nov 27 '16 13:11 sieren

This has gone to master by now. Any chance you can check this again? Else I might close this.

sieren avatar Jan 07 '17 10:01 sieren

Sorry, been so busy! Will give it a go now.

vext01 avatar Jan 27 '17 15:01 vext01

Well, it gets stuck at 100% instead of 200% now :)

qst

vext01 avatar Jan 27 '17 15:01 vext01

This was today's master built with:

cmake  -DCMAKE_PREFIX_PATH=/usr/local/lib/qt5/cmake -DCMAKE_CXX_COMPILER=eg++ -DCMAKE_C_COMPILER=egcc -DQST_BUILD_WEBKIT=1 ..

vext01 avatar Jan 27 '17 15:01 vext01

I can confirm reproducing the same issue (100% CPU usage)

tested on commit:

  • master 0bb060f Merge pull request #201 from marco-m/travis-enable-linux

mulander avatar Jan 27 '17 16:01 mulander

Seems OpenBSD specific :/ Guess there's no way around for me setting up OpenBSD and getting to the root of this.

sieren avatar Jan 27 '17 16:01 sieren