Tab-Session-Manager icon indicating copy to clipboard operation
Tab-Session-Manager copied to clipboard

Tab session manager restored tabs in the wrong order

Open Question2 opened this issue 6 years ago • 37 comments

Short description

Seems to be the same issue as : https://github.com/sienori/Tab-Session-Manager/issues/140

Loaded tabs today, and it restored them in reversed order, so for example tabs 1 - 1000, got reversed to tabs 1000 - 1. I kept loading older sessions and had to load one that was about 7 or 8 sessions old to get the right order.

Steps to reproduce

Cant reproduce on demand, session manager just loaded the tabs in the wrong order today.

Platform information

win 10 64 bit Firefox 64 ESR Version 43 of session manager I ( i just updated it to the latest version)

Additional context

Question2 avatar Jan 08 '19 00:01 Question2

Opened firefox today, tab session manager 44 loaded everything in the wrong order again. Not necessarily reversed, but jumbled up.

Question2 avatar Jan 09 '19 00:01 Question2

Same thing here, tabs load in the opposite order.

Win 10 64 bit Firefox 64.0.2 Tab Session Manager v4.4.0

azeos avatar Jan 10 '19 02:01 azeos

Similar problem: https://github.com/sienori/Tab-Session-Manager/issues/87 https://github.com/sienori/Tab-Session-Manager/issues/359

RobertAb1 avatar Jan 10 '19 11:01 RobertAb1

same Problem here, at each new Firefox and PC start, windows locations (about 10 Firefox windows active) and windows sequence are very different, not found any logic behind. Tabs inside the similar Firefox windows are matching (as wanted) and always as saved.

Win 7 64 bit Firefox 64.0.2 Tab Session Manager v4.4.0 (same at 4.3.3) if remember right, problem don´t exist at old version 3.2.0

Celtri avatar Jan 11 '19 12:01 Celtri

I can not reproduce the problem. Does it occur even if you disable other add-ons (Tree Style Tab etc)?

Please tell me the status of the option

  • Tab lazy loading
  • Use the "discarded" property for lazy loading
  • Supports Tree Style Tab

sienori avatar Jan 12 '19 14:01 sienori

I can not reproduce the problem. / I could, each new start different from the other Does it occur even if you disable other add-ons (Tree Style Tab etc)? /not installed

Please tell me the status of the option

* Tab lazy loading /**On**

* Use the "discarded" property for lazy loading/**ON**

* Supports Tree Style Tab / **-> now Off, but no difference**

Is it possible to sort the windows by Hand? The different 10 windows, still have same numbers as weeks ago, and windows 1 is always windows 1, but the windows sequences are still very different. did`t know how many possibilities there are (;-)

Celtri avatar Jan 16 '19 17:01 Celtri

@Celtri

each new start different from the other

Are you enabling Restore previous session at startup option in Tab Session Manager?

Is it possible to sort the windows by Hand? The different 10 windows, still have same numbers as weeks ago, and windows 1 is always windows 1, but the windows sequences are still very different. did`t know how many possibilities there are (;-)

Does "windows sequences" mean the order displayed in Tab Session Manager? windows sequences

sienori avatar Jan 16 '19 20:01 sienori

@Celtri

each new start different from the other

Are you enabling Restore previous session at startup option in Tab Session Manager?

Is it possible to sort the windows by Hand? The different 10 windows, still have same numbers as weeks ago, and windows 1 is always windows 1, but the windows sequences are still very different. did`t know how many possibilities there are (;-)

Does "windows sequences" mean the order displayed in Tab Session Manager? windows sequences

Yes, Option "Restore previous session at startup" option in Tab Session Manager? - is ON

Does "windows sequences" mean the order displayed in Tab Session Manager? NO- the order displayed as shown from you, is, as it should be and always correct.

The opened 10 firefox windows are not correct, not correct order and not correct (saved) place at screen.

Celtri avatar Jan 17 '19 06:01 Celtri

I have noticed that if I have the "Restore previous session at startup" option in tab session manager is on, i will get some tabs in the wrong order. But not if I have it off, at which point i guess the built in firefox session manager is taking over.

Question2 avatar Jan 30 '19 07:01 Question2

Similar here: each of the tab groups I've purposefully saved (not auto-saved groups), when opened later (few hours, next day), the window opens with all tabs loaded in Reversed Order. What was the first tab on left is opened in 'new window' as last tab on right. and the last tab on right is opened as the first tab on left and so on. Every Time. This goes for imported sessions from 'Session Manager' as well. Imported 4 windows (sessions) and all 4 were in reverse order. The last window closed (auto-saved on close), when re-opened is in the right order.

Thanks. Landis

Tab Session Manager 4.4.0
Firefox 60.5.0esr
OS: openSuSE Linux
Desktop: 
KDE 4.14.9
Kwin: 4.11.20

LandisTwo avatar Feb 01 '19 15:02 LandisTwo

@Celtri Currently, the "order of windows" (order of display, order of overlap) is not restored. When you click open session, the windows are opened in order of internal window ID. If you move the window after the session is saved, the position of the window will not be restored correctly. In the case of automatic saving, sessions are saved when the tab is opened or closed. To avoid confusion, please discuss the window order problem with another issue (In this issue we discuss the "tab order").

sienori avatar Feb 08 '19 14:02 sienori

@Question2 @azeos @LandisTwo @karlbu I can not reproduce the problem that tabs are opened in reverse order. Please tell me how to reproduce the problem. The procedure I tried is as follows.

  1. Open four tabs in one window 4 tabs
  2. Save the session saved session
  3. Open the session with "open in new window" open
  4. The session are opened in the correct order opend session

Also, my settings: settings

sienori avatar Feb 08 '19 14:02 sienori

Hi and thanks for your update.  This has been working recently, so no need to continue to track at the moment. Thank you,

Karl Buhl

On 2/8/2019 2:06 PM, RobertAb1 wrote:

To avoid confusion, please discuss the window order problem with
another issue (In this issue we discuss the "tab order").

Do you know the number of Issue where the wrong order of windows is discussed?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sienori/Tab-Session-Manager/issues/369#issuecomment-461911234, or mute the thread https://github.com/notifications/unsubscribe-auth/AL6wl3CD_gjHkBTNhMZfuUqld6mecu69ks5vLcrTgaJpZM4Z0jG6.

karlbu avatar Feb 08 '19 19:02 karlbu

Problem still exists.

Any time I would use Tab Session Manager to recover session or window, the order of tabs is wrong. Problem exists:

  1. when I am recovering session at the Firefox start,
  2. when I am opening session/window when Firefox is running.

There is also wrong windows order: https://github.com/sienori/Tab-Session-Manager/issues/375

RobertAb1 avatar Apr 06 '19 15:04 RobertAb1

There is no problem in my environment.

Here is the test session I used. It contains three 10-tab windows. testSession.zip

Please import the test session and open it. Does the problem occur?

sienori avatar Apr 06 '19 16:04 sienori

There is no problem with all 30 google pages from your test (I am talking about order of tabs).

But when I have added 3 empty tabs to one of the windows problem started to be visible. Compare 1.json and 2.json I send you by the e-mail. 1.json was the 1st session and 2.json - session after restart. Notice the shift of empty tabs.

The order in window with new tabs. BEFORE restart: 2-1 2-2 new tab 2-3 new tab new tab 2-4 2-5 2-6 2-7 2-8 2-9 2-10

AFTER restart: 2-1 2-2 2-3 new tab 2-4 new tab new tab 2-5 2-6 2-7 2-8 2-9 2-10

AFTER 2nd restart: 2-1 2-2 2-3 new tab new tab new tab 2-4 2-5 2-6 2-7 2-8 2-9 2-10

AFTER 3rd restart: 2-2 new tab new tab new tab 2-3 2-1 2-4 2-5 2-6 2-7 2-8 2-9 2-10

Create your session with pages from different domains, and repeat some of them.

Firefox build-in session restore (with TSM off) restores the order correctly.

RobertAb1 avatar Apr 06 '19 17:04 RobertAb1

Did you receive my files? Did you noticed a problem?

RobertAb1 avatar Apr 06 '19 17:04 RobertAb1

That is strange. If you provide a screen record, I might notice a problem.

sienori avatar Apr 06 '19 18:04 sienori

What should be on this screen shot?

I send you json files to your e-mail ([email protected]). Did you get them? You could test/diagnose problem on your machine.

I have also updated message above with results after two other restarts. And I could see before even more drastic changes to the order of tabs in windows, when empty tabs are located in different parts of tab strip. The order of all tabs in windows could change constantly after following restarts.

RobertAb1 avatar Apr 06 '19 19:04 RobertAb1

I can not understand the detailed reproduction procedure only with the text. Please use the video to tell me exactly how you reproduced the problem.

Thank you for taking the time to this problem.

sienori avatar Apr 06 '19 19:04 sienori

I can not understand the detailed reproduction procedure only with the text. Please use the video to tell me exactly how you reproduced the problem.

Thank you for taking the time to this problem.

It is very simple. Open Firefox with your test session you send me and in one window add in the middle 3 empty tabs by using Ctrl + T. Then restart Firefox and check the order of tabs in this window.

Alternatively, you can import one of json files I send you and restart Firefox (1 or more times) and compare the order.

RobertAb1 avatar Apr 06 '19 19:04 RobertAb1

In plain firefox, using Ctrl + T adds a new tab to the far right.

sienori avatar Apr 06 '19 19:04 sienori

I am using extension "Open Tabs Next to Current" to add new tab just on the right to the active tab.

RobertAb1 avatar Apr 06 '19 20:04 RobertAb1

Basically, please use a clean profile when reporting bugs. Does the problem occur if you disable other add-ons?

sienori avatar Apr 06 '19 20:04 sienori

Problem disappeared when I disabled just "Open Tabs Next to Current".

Interestingly, there is no problem with order of tabs when tabs are restored using Firefox build-in session management, even when "Open Tabs Next to Current" is active.

RobertAb1 avatar Apr 06 '19 20:04 RobertAb1

So we have conflict between "Tab Session Manager" and "Open Tabs Next to Current". https://addons.mozilla.org/en-US/firefox/addon/open-tabs-next-to-current/

RobertAb1 avatar Apr 06 '19 20:04 RobertAb1

The cause is probably that the tab specification of "Open Tabs Next to Current" is incorrect. Please use other add-on. https://addons.mozilla.org/ja/firefox/addon/always-right/

sienori avatar Apr 06 '19 20:04 sienori

It looks like now the problem do not appear with "Always Right". Thanks. https://addons.mozilla.org/en-US/firefox/addon/always-right/

RobertAb1 avatar Apr 06 '19 20:04 RobertAb1

@sienori

Just small suggestion. We have found conflict between "Tab Session Manager" and "Open Tabs Next to Current". Maybe it will be good idea if you can create a website in Wiki about other extensions which are not working with TSM well in Firefox, describe the type of problems users can have (or add link to discussion like here) and give the list of alternative extensions to those giving problems. You could also add on AMO a link to this Wiki page. That way you could avoid some negative ratings and reviews of your extension.

RobertAb1 avatar Apr 07 '19 12:04 RobertAb1

Open Tabs Next to Current is causing problems with Tab Session Manager: https://github.com/sblask/webextension-open-tabs-next-to-current/issues/72

I have notified developer of Open Tabs Next to Current (@sblask) about the conflict between add-ons, discussed here with @sienori on Apr 6, 2019.

@sblask comment:

(...) I have some special handling to avoid re-ordering for restored tabs. And that works well for tabs restored by Firefox directly. So I assume it the way tabs are restored by tab-session-manager.

Also the issue with the order of tabs when new tabs are present is reported often to @sblask - https://github.com/sblask/webextension-open-tabs-next-to-current/issues?q=is%3Aissue+is%3Aclosed

RobertAb1 avatar Apr 28 '19 21:04 RobertAb1