sienori
Tab group colors change and name disappear
Short description
Tab group colors change and name disappear
When I use the chrome feature to group tabs, after restoring that session, the tab group name is gone and the colors are different. Is there a way to fix this?
Steps to reproduce
- Start browser with clean profile
- Install Tab Session Manager
- open a few tabs and create tab groups.
- Give names and change the colors of the tab groups
- save the session in Tab Session Manager
- Close the browser.
- Open the browser and restore the session
Expected result
Have the session back with the same status as before
Actual result
The tabs are back, in the right order, the tab groups are back, and the tabs are assigned to the group. But, the name of the tab group is missing, and the colors have changed.
Platform information
- Platform (OS): Windows 10
- Version of browser: Chrome Version 108.0.5359.125 (Official Build) (64-bit)
- Version of Tab Session Manager: [Version 6.12.1]
Additional context
Same here. Also is the source code available for this tabs groups extension? Since it's free, maybe at least the community could help improve/bugfix it if the sourcecode was open.
I am struggling with that issue as well. The repo for the tab group extension is here, and there is an existing issue as well.
I am not proficient in javascript but I am willing to help if I can :)
By reading the relevant code, it looks like tab group titles and colors are passed to the service worker, which update the session properties.
https://github.com/sienori/Tab-Session-Manager/blob/ee7b4b852c8029fdc6c70328a45d484b548c017a/src/common/tabGroups.js#L25
So I am not sure why this still happen
By reading the relevant code, it looks like tab group titles and colors are passed to the service worker, which update the session properties.
https://github.com/sienori/Tab-Session-Manager/blob/ee7b4b852c8029fdc6c70328a45d484b548c017a/src/common/tabGroups.js#L25
So I am not sure why this still happen
could be wrong, but for me the issue is a result of tracking. If I save a session I can close and reopen it with the names still there, but if you turn on tracking then it will drop the names. I'm guessing the method that tracking uses to save the state doesn't save the group names. You can restore the names fine, but it just looks like when tracking saves the session state it doesn't preserve the names.
edit : Admittedly, I've never written a line of javascript, but I took a cursory glance around at the code and it looks like I'm right. If I can find the time I'll see if I can learn enough about javascript/extension programming to get a PR to fix the issue. (assuming I've even spotted it correctly in the first place) Could be totally in over my head on this so no promises though.
edit 2 : got a fix that (I think) works, PR #1266
That's a nice catch :) Now that you mention it I remember that I tested with a new session (no tracking) and group names were restored correctly. The sessions I have issue with are all tracked ones.
