ngx-datatable icon indicating copy to clipboard operation
ngx-datatable copied to clipboard

refactor: visibility observer

Open chintankavathia opened this issue 1 year ago • 2 comments

use ResizeObserver api to emit visibility change. Also auto recalculate table when table resize by parent containers.

What kind of change does this PR introduce? (check one with "x")

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

  • [ ] Yes
  • [x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

chintankavathia avatar Jul 09 '24 09:07 chintankavathia

@timowolf Could you please review this?

chintankavathia avatar Aug 06 '24 07:08 chintankavathia

I would like to postpone this for a while. I see chances, that we may can get rid of listening to resize events completely.

spike-rabbit avatar Mar 24 '25 12:03 spike-rabbit