ngx-datatable icon indicating copy to clipboard operation
ngx-datatable copied to clipboard

refactor: header component

Open chintankavathia opened this issue 1 year ago • 2 comments

removed unnecessary transform calculations for scrolling header along with body scroll.

What kind of change does this PR introduce? (check one with "x")

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [x] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

  • [ ] Yes
  • [x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

chintankavathia avatar Nov 12 '24 11:11 chintankavathia

I guess the better solution here would, to just use the same scrollbar for body and header. Then we can get rid of all that stuff

spike-rabbit avatar Feb 26 '25 13:02 spike-rabbit

I guess the better solution here would, to just use the same scrollbar for body and header. Then we can get rid of all that stuff

We have vertical scroll which needs to be only on body element. I cannot find any solution to have horizontal scroll common on header and body and vertical scroll only on body. 🤷

chintankavathia avatar Feb 28 '25 11:02 chintankavathia