ngx-datatable icon indicating copy to clipboard operation
ngx-datatable copied to clipboard

fix: correct height and position for inner element

Open chintankavathia opened this issue 1 year ago • 1 comments

fix datatable-selection element which is not correctly getting height and position.

steps:

  • go to any example https://siemens.github.io/ngx-datatable/
  • open inspector
  • check height and position of datatable-selection element in DOM

What kind of change does this PR introduce? (check one with "x")

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

  • [ ] Yes
  • [x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

chintankavathia avatar Nov 07 '24 08:11 chintankavathia

Not sure, if this is really the correct fix. In my opinion the actual problem here is, that this is a component, while it should be at a directive.or maybe even just merged into the datatable-scroller which itself should not be a component either.

spike-rabbit avatar Nov 07 '24 09:11 spike-rabbit

@chintankavathia please check if this is still needed. We did some changes around this.

spike-rabbit avatar Jun 27 '25 05:06 spike-rabbit

Not needed anymore

chintankavathia avatar Jun 27 '25 05:06 chintankavathia