ngx-datatable icon indicating copy to clipboard operation
ngx-datatable copied to clipboard

fix(datatable-body): avoid multiple calculations and update properly on changes

Open Killusions opened this issue 1 year ago • 3 comments

This starts to improve the issues caused by the many setters and getters, while it does not fully solve some of the OnPush issues I encountered, it at least helps with some them.

Killusions avatar Oct 22 '24 15:10 Killusions

@chintankavathia It seems due to the bottomSummaryRowsStyles = computed(() the cache is prematurely accessed.

Killusions avatar Oct 22 '24 16:10 Killusions

@chintankavathia It seems due to the bottomSummaryRowsStyles = computed(() the cache is prematurely accessed.

Just made it wait for it

Killusions avatar Oct 22 '24 21:10 Killusions

@chintankavathia Before I go ahead here, can you check if it conflicts with something?

Killusions avatar Oct 22 '24 21:10 Killusions