ix
ix copied to clipboard
feat(core/date-/datetime-input): Add new components ix-date-input and ix-datetime-input
Pull request checklist
Please check if your PR fulfills the following requirements:
- [x] Tests for the changes have been added (for bug fixes / features)
- [x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
- [x] Build (
yarn build
) was run locally and any changes were pushed - [x] Unit tests (
yarn test
) were run locally and passed - [x] Visual Regression Tests (
yarn visual-regression
) were run locally and passed - [x] Linting (
npm lint
) was run locally and passed
Pull request type
Please check the type of change your PR introduces:
- [ ] Bug fix
- [x] Feature
- [ ] Refactoring (no functional changes, no API changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):
What is the new behavior?
- New ix-date-input component that uses the ix-date-picker-rework
- New ix-datetime-input component that uses the ix-datetime-picker-rework
Does this introduce a breaking change?
- [ ] Yes
- [x] No
Testing
Added component tests and snapshot tests for both components
Adresses second bullet point from #384
a11y support
https://github.com/siemens/ix/pull/861/commits/6e53d8156018a691a86620967f81d349c71542c9
disabled state/property for new components
https://github.com/siemens/ix/pull/861/commits/c2ba2a6dda1492fa19c66b6046c030aaa86ff1a4
[IX-641] has some UX TBDs that need to be clarified before this can be finalized
This fix does not adress this JSDoc at all. Am I missing something?
https://github.com/siemens/ix/pull/861/commits/9cc640e74b53051ef73cbd6aec9120dff3ad28d5
Looking at Figma there seems to be too much margin around the arrow still
I don't know how to implement 1:1 representation of the figma spec. I am now setting the width of the inputs based on the placeholder attribute, which is usually wider than an entered value, which makes it appear to have more margin.
https://github.com/siemens/ix/pull/861/commits/5af1fea38ed16dd47848a314656839e656fcbbac
Maybe default should be false? TBD with UX team
https://github.com/siemens/ix/pull/861/commits/b455531aa2f68dba31fd5d3f58ad1c65d5cff183
VRT for disabled state is missing VRT for label positions are missing
https://github.com/siemens/ix/pull/861/commits/e3c4d4f16c721a270eceb9fe427ca58651321bb3
⚠️ No Changeset found
Latest commit: 75cd835f38701ccd7fa577c110e9de8664c64f44
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Will be implemented with #1318