ix icon indicating copy to clipboard operation
ix copied to clipboard

feat(core/date-/datetime-input): Add new components ix-date-input and ix-datetime-input

Open lzeiml opened this issue 1 year ago • 9 comments

Pull request checklist

Please check if your PR fulfills the following requirements:

  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • [x] Build (yarn build) was run locally and any changes were pushed
  • [x] Unit tests (yarn test) were run locally and passed
  • [x] Visual Regression Tests (yarn visual-regression) were run locally and passed
  • [x] Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • [ ] Bug fix
  • [x] Feature
  • [ ] Refactoring (no functional changes, no API changes)
  • [ ] Build related changes
  • [ ] Documentation content changes
  • [ ] Other (please describe):

What is the new behavior?

  • New ix-date-input component that uses the ix-date-picker-rework
  • New ix-datetime-input component that uses the ix-datetime-picker-rework

Does this introduce a breaking change?

  • [ ] Yes
  • [x] No

Testing

Added component tests and snapshot tests for both components

lzeiml avatar Oct 19 '23 09:10 lzeiml

Adresses second bullet point from #384

nuke-ellington avatar Nov 16 '23 08:11 nuke-ellington

a11y support

https://github.com/siemens/ix/pull/861/commits/6e53d8156018a691a86620967f81d349c71542c9

lzeiml avatar Nov 20 '23 14:11 lzeiml

disabled state/property for new components

https://github.com/siemens/ix/pull/861/commits/c2ba2a6dda1492fa19c66b6046c030aaa86ff1a4

lzeiml avatar Nov 21 '23 09:11 lzeiml

[IX-641] has some UX TBDs that need to be clarified before this can be finalized

nuke-ellington avatar Nov 22 '23 10:11 nuke-ellington

This fix does not adress this JSDoc at all. Am I missing something?

https://github.com/siemens/ix/pull/861/commits/9cc640e74b53051ef73cbd6aec9120dff3ad28d5

lzeiml avatar Nov 27 '23 12:11 lzeiml

Looking at Figma there seems to be too much margin around the arrow still

I don't know how to implement 1:1 representation of the figma spec. I am now setting the width of the inputs based on the placeholder attribute, which is usually wider than an entered value, which makes it appear to have more margin.

https://github.com/siemens/ix/pull/861/commits/5af1fea38ed16dd47848a314656839e656fcbbac

lzeiml avatar Nov 27 '23 12:11 lzeiml

Maybe default should be false? TBD with UX team

https://github.com/siemens/ix/pull/861/commits/b455531aa2f68dba31fd5d3f58ad1c65d5cff183

lzeiml avatar Nov 27 '23 12:11 lzeiml

VRT for disabled state is missing VRT for label positions are missing

https://github.com/siemens/ix/pull/861/commits/e3c4d4f16c721a270eceb9fe427ca58651321bb3

lzeiml avatar Nov 27 '23 12:11 lzeiml

⚠️ No Changeset found

Latest commit: 75cd835f38701ccd7fa577c110e9de8664c64f44

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Apr 04 '24 13:04 changeset-bot[bot]

Will be implemented with #1318

danielleroux avatar Jun 24 '24 14:06 danielleroux