ix icon indicating copy to clipboard operation
ix copied to clipboard

refactor(core): replace internal comments with annotations

Open AndreasBerliner opened this issue 1 year ago โ€ข 2 comments

๐Ÿ’ก What is the current behavior?

GitHub Issue Number: #<ISSUE NUMBER>

๐Ÿ†• What is the new behavior?

๐Ÿ Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • [ ] ๐Ÿฆฎ Accessibility (a11y) features were implemented
  • [ ] ๐Ÿ—บ๏ธ Internationalization (i18n) - no hard coded strings
  • [ ] ๐Ÿ“ฒ Responsiveness - components handle viewport changes and content overflow gracefully
  • [x] ๐Ÿ“„ Documentation was reviewed/updated (pnpm run docs)
  • [ ] ๐Ÿงช Unit tests were added/updated and pass (pnpm test)
  • [ ] ๐Ÿ“ธ Visual regression tests were added/updated and pass (Guide)
  • [ ] ๐Ÿง Static code analysis passes (pnpm lint)
  • [x] ๐Ÿ—๏ธ Successful compilation (pnpm build, changes pushed)

๐Ÿ‘จโ€๐Ÿ’ป Help & support

AndreasBerliner avatar Jul 18 '24 10:07 AndreasBerliner

๐Ÿฆ‹ Changeset detected

Latest commit: 078d7c85f6e61fa08bbfd05890b98e0c0974bc54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@siemens/ix-angular Major
@siemens/ix-aggrid Major
@siemens/ix-react Major
@siemens/ix Major
@siemens/ix-vue Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jul 18 '24 10:07 changeset-bot[bot]

Report of strictNullChecks (strictPropertyInitialization) check

Typescript check

You decreased the total number of errors in PR branch by 3 ๐ŸŽ‰

ESLint check

Total ESLint warnings are the same in both branches

github-actions[bot] avatar Jul 18 '24 10:07 github-actions[bot]