Forms overhaul (including several components)
๐ก What is the current behavior?
GitHub Issue Number: #<ISSUE NUMBER>
๐ What is the new behavior?
Introduce new validation concept with new components:
- ix-text-field
- ix-number-field
- ix-textarea-field
- ix-date-field
- ix-checkbox
- ix-radio
- ix-custom-field
๐ Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
- [ ] ๐ฆฎ Accessibility (a11y) features were implemented
- [ ] ๐บ๏ธ Internationalization (i18n) - no hard coded strings
- [ ] ๐ฒ Responsiveness - components handle viewport changes and content overflow gracefully
- [ ] ๐ Documentation was reviewed/updated (
pnpm run docs) - [ ] ๐งช Unit tests were added/updated and pass (
pnpm test) - [ ] ๐ธ Visual regression tests were added/updated and pass (Guide)
- [ ] ๐ง Static code analysis passes (
pnpm lint) - [ ] ๐๏ธ Successful compilation (
pnpm build, changes pushed)
๐จโ๐ป Help & support
๐ฆ Changeset detected
Latest commit: 5e3a9aae9456acb4a11b1454c2f18f5211812e24
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 5 packages
| Name | Type |
|---|---|
| @siemens/ix-angular | Minor |
| @siemens/ix-react | Minor |
| @siemens/ix | Minor |
| @siemens/ix-vue | Minor |
| @siemens/ix-aggrid | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
/snapshots:approve --args=form-fields.e2e.ts
/release:pr
Please add a changeset via pnpm changeset before attempting a snapshot release.
/release:pr
/release:pr
A new release has been made for this PR. You can install it with:
Core library:
npm i @siemens/[email protected]
Angular:
npm i @siemens/[email protected]
React:
npm i @siemens/[email protected]
Vue:
npm i @siemens/[email protected]
Deploy Preview for industrial-experience ready!
| Name | Link |
|---|---|
| Latest deploy log | https://app.netlify.com/sites/industrial-experience/deploys/668652bfd49ccf969a9b4b1e |
| Deploy Preview | https://pr-preview-1318--industrial-experience.netlify.app |
Report of strict check
src/components/date-dropdown/date-dropdown.tsx
- src/components/date-dropdown/date-dropdown.tsx(191,20): error TS2564: Property 'selectedDateRangeId' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'selectedDateRangeId' has no initializer and is not definitely assigned in the constructor.
src/components/select/select.tsx
- src/components/select/select.tsx(308,9): error TS2345: Argument of type 'HTMLIxDropdownElement | undefined' is not assignable to parameter of type 'HTMLElement'.: error TS2345: Argument of type 'HTMLIxDropdownElement | undefined' is not assignable to parameter of type 'HTMLElement'.
- src/components/select/select.tsx(314,33): error TS2345: Argument of type 'HTMLIxDropdownElement | undefined' is not assignable to parameter of type 'Node'.: error TS2345: Argument of type 'HTMLIxDropdownElement | undefined' is not assignable to parameter of type 'Node'.
- src/components/select/select.tsx(359,5): error TS2322: Type 'null' is not assignable to type 'DropdownItemWrapper | undefined'.: error TS2322: Type 'null' is not assignable to type 'DropdownItemWrapper | undefined'.
- src/components/select/select.tsx(405,5): error TS2532: Object is possibly 'undefined'.: error TS2532: Object is possibly 'undefined'.
- src/components/select/select.tsx(452,5): error TS2322: Type '(string | undefined)[]' is not assignable to type 'string[]'.: error TS2322: Type '(string | undefined)[]' is not assignable to type 'string[]'.
- src/components/select/select.tsx(471,37): error TS2345: Argument of type 'null' is not assignable to parameter of type 'string[] | undefined'.: error TS2345: Argument of type 'null' is not assignable to parameter of type 'string[] | undefined'.
- src/components/select/select.tsx(522,7): error TS2322: Type 'null' is not assignable to type 'DropdownItemWrapper | undefined'.: error TS2322: Type 'null' is not assignable to type 'DropdownItemWrapper | undefined'.
- src/components/select/select.tsx(556,24): error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.: error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
- src/components/select/select.tsx(625,7): error TS2532: Object is possibly 'undefined'.: error TS2532: Object is possibly 'undefined'.
- src/components/select/select.tsx(700,12): error TS18048: 'item.label' is possibly 'undefined'.: error TS18048: 'item.label' is possibly 'undefined'.
- src/components/select/select.tsx(804,5): error TS2322: Type 'Promise<HTMLInputElement | undefined>' is not assignable to type 'Promise<HTMLInputElement>'.: error TS2322: Type 'Promise<HTMLInputElement | undefined>' is not assignable to type 'Promise<HTMLInputElement>'.
- src/components/select/select.tsx(883,23): error TS2322: Type 'null' is not assignable to type 'DropdownItemWrapper | undefined'.: error TS2322: Type 'null' is not assignable to type 'DropdownItemWrapper | undefined'.
Quality Gate passed
Issues
0 New issues
18 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
1.9% Duplication on New Code