ix icon indicating copy to clipboard operation
ix copied to clipboard

Remove margin from ix-message-bar

Open TDaniel-evo opened this issue 1 year ago • 1 comments

Prerequisites

  • [x] I have not leaked any internal company information.
  • [X] I have not posted internal links or code snippets.

What happened?

ix-message-bar component has margins on two sides. We don't need that and it breaks the layout. image

What type of frontend frameware are you seeing the problem on?

Angular

Which version of iX do you use?

2.0.3

Code to produce this issue.

<ix-message-bar>Message text</ix-message-bar>

TDaniel-evo avatar Jan 30 '24 10:01 TDaniel-evo

Internal ref [IX-874]

matthiashader avatar Feb 06 '24 10:02 matthiashader

Is there any update on this? Is this PR related? https://github.com/siemens/ix/pull/1064

TDaniel-evo avatar Jun 07 '24 13:06 TDaniel-evo

Instead of removing the right and left margins, additional top margin has been added. Is this the expected solution? image

TDaniel-evo avatar Jun 07 '24 14:06 TDaniel-evo

The PR moved the margin property from a shadowRoot selector to the host element https://github.com/siemens/ix/pull/1064/files#diff-8185c60fb032d26864d303d4b1dc083986381a7e6e3036249e3500d485451ef6

This makes is possible to overwrite the default margin:

margin: 0px;

danielleroux avatar Jun 10 '24 05:06 danielleroux

Thank you. I am closing this issue then.

TDaniel-evo avatar Jun 10 '24 10:06 TDaniel-evo