Siegfried Pammer

Results 199 comments of Siegfried Pammer

Thank you very much for your pull request! The changes are looking good, just a few remarks: 1) Can you please clean up the commits? 3 of the 4 commits...

I normally use the `gitk` UI tool for this as it's more convenient and you don't have to remember commit hashes. Also the command-line instructions might not use the minimal...

Looks like this didn't work out as expected. If you want, I can just clean it up manually before merge.

Hmmm, it seems, this change currently does not provide a out-of-the-box solution for users of AvalonEdit. I would have expected Narrator to properly work out-of-the-box with how we currently use/instantiate...

> I wasn't sure of a great test for changing text while someone has an active selection. You could add a DispatcherTimer to the sample application, which modifies the document...

This is likely because AvalonEdit only has syntax highlighting for variants of JS from the stone age. We will gladly accept a PR that fixes this!

You can take a look at SharpDevelop's console implementation based on AvalonEdit: https://github.com/icsharpcode/SharpDevelop/blob/3f3ae2a5d4ffafd98cdf1c09308b9b8d93b0356c/src/Main/Base/Project/Src/Gui/Pads/AbstractConsolePad.cs Especially https://github.com/icsharpcode/SharpDevelop/blob/3f3ae2a5d4ffafd98cdf1c09308b9b8d93b0356c/src/Main/Base/Project/Src/Gui/Pads/AbstractConsolePad.cs#L319 Hope this helps!

I have no experience with JAWS or any other narrator. Would you be able to provide some resources on the topic and then we might be able to add better...

Thank you for posting this! Yes, I would be interested in reviewing and testing a PR from you @sloutsky. However, I might not be able to focus on this topic...