Sid Vishnoi

Results 203 comments of Sid Vishnoi

@raducristianpopa Can we create [this comment](https://github.com/interledger/web-monetization-extension/pull/270#issuecomment-2117056481) as PR author? Everything I get a notification I think you reviewed.

Closing in favour of https://github.com/interledger/web-monetization-extension/pull/305

@tselit Yes, we referred to it also. But for this document, we need a stable doc for basic setup (not something we want users to test in specific releases). Note...

> Do we need the "Obtain a public-private key pair and key ID" steps for the WM extension doc? @melissahenderson We forgot to update heading there. We actually want a...

Developer's guide mostly answers this now, even if not as detailed on each step.

[Rafiki v1.0.0-alpha.16](https://github.com/interledger/rafiki/releases/tag/v1.0.0-alpha.16) improved performance a lot. But there's still some slowdown when sending multiple concurrent requests. Looking forward to more improvements before we move to this.

On a second thought, I think it should not be exposed to Window (spec bug). If `MonetizationCurrencyAmount` maps directly to `PaymentCurrencyAmount`, why it's an interface and not a dictionary like...

We cannot use a `dictionary` as the attribute type of a member in an `interface` (here `MonetizationEvent`) - [WebIDL prohibits it](https://webidl.spec.whatwg.org/#idl-dictionaries:~:text=Dictionaries%20must%20not%20be%20used%20as%20the%20type%20of%20an%20attribute%20or%20constant.). Even if the definition was same as `PaymentCurrencyAmount`, the...

Also see: https://developer.mozilla.org/en-US/docs/Web/API/Speculation_Rules_API

Too much work to handle this with little benefit, and can make extension less reliable. Let's close it. Benefit: we might be able to start monetization like 200-400ms earlier.