Sid Vishnoi

Results 200 comments of Sid Vishnoi

Hey! I got a chance to try running this with g++ 9.1.0. Couldn't reproduce this bug there unfortunately. If I get my hands on 8.3.0, I'll try again and let...

I've manually run update script on server. Keeping this issue open to automate it in future.

Updated manually server. We don't currently have a cron setup to fetch list of groups from API.

Another use case: we run automated end-to-end tests with Playwright and upload test results as artifact, which can contain sensitive information. We want those artifacts available only to a restricted...

Also relevant bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1573659 Firefox MV3 doesn't support service worker as of now. We might need separate implementation wrappers as background script/service worker. Edit: Actually won't need two implementations, as...

Another difference we need to handle: By default, MV3 disables our all hosts permissions. That's something we need to request user, otherwise much of the extension won't work - can...

Also, not a blocker, but Firefox doesn't support content script execution world yet as mentioned in https://github.com/interledger/web-monetization-extension/issues/9. https://bugzilla.mozilla.org/show_bug.cgi?id=1736575 So, we'll have to stick with the inject `script.innerHTML` hack for now....

Ok, found the best bug yet. Thanks to webpack (or our configuration). It adds a `document` to `background.js`, but Chrome MV3 (with Service Worker) doesn't support document, so I kept...

Question: @tselit @ioana-chiorean @raducristianpopa @dianafulga Should we remove manifest v2 support, or continue to support it? I found extension worked fine with Firefox MV3.

Please check linked PR about Firefox/Chrome Script/SW, I added a review comment there about this. Basically we aren't using anything particular about service worker, so a script is exactly same...