node-mysql2
node-mysql2 copied to clipboard
fix(stream): reads should emit the dataset number for each dataset
This PR is a debug/fix of #2496, preserving all its commits.
Testing locally:
seq 1000 | xargs -I {} sh -c 'FILTER=test-multi-result-streaming npm run test || echo "Failure at iteration {}" >> failures.log'
- I ran all the CI 3 times, just to make sure.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.32%. Comparing base (
9edfd72
) to head (f98476d
). Report is 28 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #2628 +/- ##
=======================================
Coverage 90.32% 90.32%
=======================================
Files 71 71
Lines 15727 15727
Branches 1339 1339
=======================================
Hits 14206 14206
Misses 1521 1521
Flag | Coverage Δ | |
---|---|---|
compression-0 | 90.32% <100.00%> (ø) |
|
compression-1 | 90.32% <100.00%> (ø) |
|
tls-0 | 89.85% <100.00%> (ø) |
|
tls-1 | 90.15% <100.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Just confirming from mysqljs side before merging:
- https://github.com/mysqljs/mysql/blob/dc9c152a87ec51a1f647447268917243d2eab1fd/lib/protocol/sequences/Query.js#L210-L213
- https://github.com/mysqljs/mysql/blob/dc9c152a87ec51a1f647447268917243d2eab1fd/lib/protocol/sequences/Query.js#L223-L225
I also tested on Deno's latest tests and all worked properly.