node-mysql2 icon indicating copy to clipboard operation
node-mysql2 copied to clipboard

add sqlMessage to QueryError interface

Open mxw opened this issue 3 years ago • 4 comments

it should be there; it's usually set. also delete redundant comments of the form /** the variable name, but with spaces */.

mxw avatar Aug 06 '21 15:08 mxw

thanks @mxw . I'm not an expert in TS typings, would it be possible to somehow validate typings from unit tests? Currently if we accidentally break something it's not visible until somebody using this module with TS starts to complain

sidorares avatar Aug 07 '21 00:08 sidorares

i'm just barely aware that unit tests for typings exist, because i happened upon this today: https://github.com/discordjs/discord.js/blob/main/typings/tests.ts

but i'm not familiar with how they work or best practices; i'm a regular TS user but don't maintain any TS libraries myself.

mxw avatar Aug 07 '21 01:08 mxw

I guess just running TS compiler against some codebase that uses typings would be a test

sidorares avatar Aug 07 '21 03:08 sidorares

+1 I would love to get this implemented instead of having to setup global overrides just to polyfill that property back in.

atlc avatar Dec 12 '23 19:12 atlc