node-mysql2 icon indicating copy to clipboard operation
node-mysql2 copied to clipboard

exposing pool cluster in the promise-based implementations

Open alpacamybags118 opened this issue 4 years ago • 2 comments

Originally my changes were to expose query as a function of PoolCluster (as it was in the mysqljs library - https://github.com/mysqljs/mysql/blob/3430c513d6b0ca279fb7c79b210c9301e9315658/lib/PoolNamespace.js#L58)

In order to achieve that, I had to expose PoolCluster in the promise based implementation. This exposes PoolCluster in promise.js, along with adding the types in the promise typing files.

This is my first time working on the code for this library, so any feedback would be appreciated! I tried to follow the same coding practices and styles as much as I could.

alpacamybags118 avatar Dec 08 '20 21:12 alpacamybags118

It would be great to have execute() as well.

vlasky avatar Dec 17 '20 10:12 vlasky

added execute as well!

alpacamybags118 avatar Jan 08 '21 01:01 alpacamybags118