sideshowbarker

> I guess we could factor the Sphinx part of that `bikeshed` target into its own target — in which case, we could make the build run that part just...

> Yes, the biggest time & resource sink in CI is setting up the prerequisite software. But you can't share that across actions, you can only share artefacts via "upload"....

> @sideshowbarker, is there anything missing for merging this? Nope, nothing missing — it’s ready to be merged

https://github.com/WebAssembly/spec/actions/runs/8133065435/job/22233472624?pr=1737#step:7:3005 says: > Must provide W3C_ECHIDNA_TOKEN_CORE and DECISION_URL environment variables …but at https://github.com/WebAssembly/spec/blob/main/.github/workflows/ci-spec.yml#L124 , the CI build sets `W3C_ECHIDNA_TOKEN_CORE` — and in the makefile here: https://github.com/WebAssembly/spec/blob/89f7ced5e149cbdc3a6f2d661b0e5f7da0b45925/document/core/Makefile#L12 …`DECISION_URL` is hardcoded. And...

OK, first clue: Looking at https://pipelinesghubeus4.actions.githubusercontent.com/k4KMVVeRi9EEw2vuQiOaD2iDjWSjf8j5KDSnrjfdb62mXBfQf1/_apis/pipelines/1/runs/1014/signedlogcontent/2?urlExpires=2024-03-04T12%3A23%3A05.0263402Z&urlSigningMethod=HMACV1&urlSignature=UGaJewwi8Aq1yCtlo9EA1LTL5QbS246pUMl61Bjn2RI%3D raw log for the https://github.com/WebAssembly/spec/pull/1730 PR branch before we merged, I see: ``` 2024-02-19T06:32:52.0833801Z env: 2024-02-19T06:32:52.0834120Z STATUS: --md-status=WD 2024-02-19T06:32:52.0834795Z W3C_ECHIDNA_TOKEN_CORE: *** 2024-02-19T06:32:52.0835312Z W3C_ECHIDNA_TOKEN_JSAPI: ***...

OK, looking at https://github.com/WebAssembly/spec/settings/secrets/actions, I see these statements: > Anyone with collaborator access to this repository can use these secrets and variables for actions. **They are not passed to workflows...

> in fact PRs should probably never cause a push to the w3c repo, only actual pushes to the main branch should. OK > That probably means that we'll have...

> split the publish-to-w3c job into a separate workflow file without the `on: pull_request` trigger. OK, opened https://github.com/WebAssembly/spec/pull/1738 for that

I haven’t been able to make time to consider this issue in detail yet, but from my experience over years of reading and answering CORS questions on Stack Overflow, I...

FYI, I moved setting of the `IgnoreInertNodes` option into the platform code in `UIProcess/mac/WKTextFinderClient.mm` and in `UIProcess/API/glib/WebKitFindController.cpp` — because the OptionSet it gets added to then gets used/shared in multiple...