talos icon indicating copy to clipboard operation
talos copied to clipboard

docs: added documentation for kubevirt on Talos

Open MichaelTrip opened this issue 1 year ago • 1 comments

Pull Request

Added documentation for KubeVirt on Talos, as discussed with @rothgar :smile:

What? (description)

Added documentation on how to setup KubeVirt on Talos. I have used resources and my experience that i shared on TalosCon 2024.

Why? (reasoning)

To give people a basic understanding on how to run KubeVirt on Talos.

Acceptance

Please use the following checklist:

  • [ ] you linked an issue (if applicable)
  • [ ] you included tests (if applicable)
  • [ ] you ran conformance (make conformance)
  • [ ] you formatted your code (make fmt)
  • [ ] you linted your code (make lint)
  • [x] you generated documentation (make docs)
  • [ ] you ran unit-tests (make unit-tests)

MichaelTrip avatar Oct 18 '24 09:10 MichaelTrip

Thanks for the PR! I added of suggestions for grammer and format preferences. If you want to review/accept them we'll need to squash the commits and force push to the branch.

I'll double check after we address the existing comments.

rothgar avatar Oct 18 '24 22:10 rothgar

Thanks for the PR! I added of suggestions for grammer and format preferences. If you want to review/accept them we'll need to squash the commits and force push to the branch.

I'll double check after we address the existing comments.

Hi Justin,

Is there something else I need to do for this PR? Please let me know.

MichaelTrip avatar Nov 10 '24 06:11 MichaelTrip

Thanks Michael, Sorry I was at Kubecon all last week. I'll get this rebased, squash commits, and signed so we can merge it.

rothgar avatar Nov 20 '24 06:11 rothgar

Thanks Michael, Sorry I was at Kubecon all last week. I'll get this rebased, squash commits, and signed so we can merge it.

No problem :) Thanks for replying!

MichaelTrip avatar Nov 21 '24 19:11 MichaelTrip

Moved to #9782

rothgar avatar Nov 21 '24 23:11 rothgar