talos
talos copied to clipboard
Bond Primary Device Selector
Feature Request
Description
Currently, bonds can use a deviceSelector to select its slaves, but the primary field used by active-backup/balance-tlb/balance-alb seems to still require a hardcoded interface name string.
I propose that the primary field support a deviceSelector to make the configuration experience consistent and avoid hardcoding the interface names in any parts of the configuration.
Current Configuration Example
- &m720q-net
interface: bond0
mtu: 9000
dhcp: false
bond: &bond0
mode: active-backup
miimon: 100
primary: enp1s0 # <-- NOTE: currently this must be a string
deviceSelectors:
# Mellanox ConnectX (enp1s0)
- driver: "mlx4_core"
hardwareAddr: "*:80"
# onboard I219-V NIC (eno1)
- driver: "e1000e"
hardwareAddr: "*:12"
Proposed Configuration Example
- &m720q-net
interface: bond0
mtu: 9000
dhcp: false
bond: &bond0
mode: active-backup
miimon: 100
primaryDeviceSelector: # <-- NOTE: deviceSelector type instead of string
# Mellanox ConnectX (enp1s0)
driver: "mlx4_core"
hardwareAddr: "*:80"
deviceSelectors:
# Mellanox ConnectX (enp1s0)
- driver: "mlx4_core"
hardwareAddr: "*:80"
# onboard I219-V NIC (eno1)
- driver: "e1000e"
hardwareAddr: "*:12"
This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.
Not stale, I'm still interested in this feature request.
This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.
Not stale, I'm still interested in this feature request.
still not stale