talos icon indicating copy to clipboard operation
talos copied to clipboard

Bond Primary Device Selector

Open JJGadgets opened this issue 1 year ago • 4 comments

Feature Request

Description

Currently, bonds can use a deviceSelector to select its slaves, but the primary field used by active-backup/balance-tlb/balance-alb seems to still require a hardcoded interface name string.

I propose that the primary field support a deviceSelector to make the configuration experience consistent and avoid hardcoding the interface names in any parts of the configuration.

Current Configuration Example

      - &m720q-net
        interface: bond0
        mtu: 9000
        dhcp: false
        bond: &bond0
          mode: active-backup
          miimon: 100
          primary: enp1s0 # <-- NOTE: currently this must be a string
          deviceSelectors:
            # Mellanox ConnectX (enp1s0)
            - driver: "mlx4_core"
              hardwareAddr: "*:80"
            # onboard I219-V NIC (eno1)
            - driver: "e1000e"
              hardwareAddr: "*:12"

Proposed Configuration Example

      - &m720q-net
        interface: bond0
        mtu: 9000
        dhcp: false
        bond: &bond0
          mode: active-backup
          miimon: 100
          primaryDeviceSelector: # <-- NOTE: deviceSelector type instead of string
            # Mellanox ConnectX (enp1s0)
            driver: "mlx4_core"
            hardwareAddr: "*:80"
          deviceSelectors:
            # Mellanox ConnectX (enp1s0)
            - driver: "mlx4_core"
              hardwareAddr: "*:80"
            # onboard I219-V NIC (eno1)
            - driver: "e1000e"
              hardwareAddr: "*:12"

JJGadgets avatar Jun 12 '24 22:06 JJGadgets

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Dec 10 '24 02:12 github-actions[bot]

Not stale, I'm still interested in this feature request.

JJGadgets avatar Dec 10 '24 22:12 JJGadgets

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jun 09 '25 02:06 github-actions[bot]

Not stale, I'm still interested in this feature request.

JJGadgets avatar Jun 10 '25 01:06 JJGadgets

still not stale

dezren39 avatar Oct 09 '25 11:10 dezren39