talos icon indicating copy to clipboard operation
talos copied to clipboard

`talosctl dashboard` claims "terminal type unsupported" for tmux-256color, et al

Open fahhem opened this issue 1 year ago • 1 comments

Bug Report

$ talosctl dashboard
terminal type unsupported
$ TERM=tmux talosctl dashboard
terminal type unsupported
$ TERM=xterm-256color talosctl dashboard
[dashboard launches]

Description

It seems terminal detection is very tight, rather than being capability based (terminfo) or by checking terminal families.

I looked only a little bit, and it seems talosctl uses tcell, which does mention tmux support in their latest releases. I'm not sure where the check against $TERM is happening that causes talosctl to support fewer terminal types.

Logs

Environment

  • Talos version:
Client:
        Tag:         v1.7.1
        SHA:         e9cb904e
        Built:       
        Go version:  go1.22.2
        OS/Arch:     linux/amd64
  • Kubernetes version: n/a
  • Platform: Ubuntu 23.04 Linux 6.2.0-39

fahhem avatar May 18 '24 20:05 fahhem