Add support to wipe additional disks

[ammmze]

Feature Request

It would be great if the talos installer could wipe additional disks during install and/or upgrade.

Description

I envision something like the following configuration to wipe additional disks. It would allow you wipe multiple additional disks based on given selectors similar to the install disk selector. Perhaps it would be useful wipe the disk on upgrade?

machine:
  install:
    wipeDisks:
      # wipe disks that are 4GB on install or upgrade
      - on: [install, upgrade]
        selector:
          size: 4GB
      # wipe western digital disks
      - on: [install]
        selector:
          model: WDC*

[smira]

See also: #2213

[kardiojack]

Just wanted to say I would also find this very useful. As far as I can tell, if I accidentally create a formatted partition on a disk, either before installing Talos or in during a talosctl upgrade, I can't use that drive with Rook/Ceph. The only workaround (I think) is to boot into a rescue system and dd the drive, or use a privileged pod which I don't know how to do and feels risky.

[vorburger]

@smira @andrewrynhard this issue does seems a dupe of #2213, perhaps you would like to close this issue, to have 1 less? 😸 The syntax proposed there (wipe: true within machine: disks:) is where I intuitively looked for it; adding a new wipeDisks section seems less intuitive, to me. I've left a comment on the issue re. on: [install, upgrade].

[smira]

talosctl reset now has an option to pass additional (user) disks to wipe explicitly