talos-cloud-controller-manager icon indicating copy to clipboard operation
talos-cloud-controller-manager copied to clipboard

feat: talos version on transformation rules

Open sergelogvinov opened this issue 7 months ago • 3 comments

Since containerd2 does not include a TUN device by default, we can label the node based on the Talos version and deploy additional pods accordingly.

Pull Request

What? (description)

Why? (reasoning)

https://github.com/siderolabs/talos-cloud-controller-manager/issues/232

Acceptance

Please use the following checklist:

  • [x] you linked an issue (if applicable)
  • [ ] you included tests (if applicable)
  • [ ] you ran conformance (make conformance)
  • [x] you linted your code (make lint)
  • [x] you linted your code (make unit)

See make help for a description of the available targets.

sergelogvinov avatar Jun 04 '25 08:06 sergelogvinov

In fact, this change was reverted back in containerd/runc, so latest Talos version have tun by default "as before".

So not sure if this is needed vs. just upgrading Talos.

smira avatar Jun 04 '25 14:06 smira

In fact, this change was reverted back in containerd/runc, so latest Talos version have tun by default "as before".

So not sure if this is needed vs. just upgrading Talos.

Thank you for the information. These are very good changes. These changes were made in response to a community request, aiming to implement logic based on the Talos version. I wrote the commit message based on my experience after upgrading the OS.

sergelogvinov avatar Jun 04 '25 14:06 sergelogvinov

Yeah, probably we can put it on hold.

sergelogvinov avatar Jun 04 '25 14:06 sergelogvinov