talos-backup icon indicating copy to clipboard operation
talos-backup copied to clipboard

feature: additional s3 configuration flags

Open egallis31 opened this issue 1 year ago • 3 comments

The default aws-go-sdk-v2 configuration for the S3 client appears to be using the addressing_style of auto, as is default. To upload to Minio, in most cases path style is utilized.

Based on how the package operates it appears that the only way to change the addessing_style is via the object itself, no environment variables available officially, and does not seem to respect aws config file for configuration flags.

potential update for s3.go - https://stackoverflow.com/a/66141318

Requesting this additional feature addition for usage with Minio for S3 backup.

egallis31 avatar Jul 13 '24 01:07 egallis31

not sure what's missing, this already works with minio and as we use minio in integration tests

frezbo avatar Jul 14 '24 18:07 frezbo

I had a problem and this issue put me on the right track.

Since the v0.1.0-beta.1 release we can't send snapshots to our minio cluster, the URL it builds and tries to resolve does not exist because it is bucket.s3endpoint.tld

So out of curiosity I downgraded to v0.1.0-beta.0 and it works, so it seems to me that there's indeed something fishy about how the URL is built in the latest version.

cgrard avatar Jul 19 '24 11:07 cgrard

I have the same problem. Any workarounds ?

UPD: Downgrade to v0.1.0-beta.0 is solves that problems. Hope you will add additional flag to enable\disable host-style or path-style endpoint

NikolaiBessonov avatar Aug 07 '24 10:08 NikolaiBessonov

I had a problem and this issue put me on the right track.

Since the v0.1.0-beta.1 release we can't send snapshots to our minio cluster, the URL it builds and tries to resolve does not exist because it is bucket.s3endpoint.tld

So out of curiosity I downgraded to v0.1.0-beta.0 and it works, so it seems to me that there's indeed something fishy about how the URL is built in the latest version.

Same problem here @frezbo

iamrubeng avatar Aug 27 '24 08:08 iamrubeng

I have a PR submitted and waiting for approval for this : https://github.com/siderolabs/talos-backup/pull/20

cgrard avatar Aug 27 '24 09:08 cgrard

https://github.com/siderolabs/talos-backup/releases/tag/v0.1.0-beta.2 should have a fix

frezbo avatar Aug 27 '24 11:08 frezbo