pkgs icon indicating copy to clipboard operation
pkgs copied to clipboard

feat: fix Mellanox Build & add missing Kernel Flags

Open feniarus opened this issue 1 year ago • 2 comments

This PR is for fixing the Mellanox OFED Driver Package and adding the missing Kernel Flags for it to build. The NVME Part of the Dirver is disabled because it has Source Code related problems.

Signed-off-by: Feniarus [email protected]

feniarus avatar Oct 05 '24 14:10 feniarus

The NVME Part of the Dirver is disabled because it has Source Code related problems

Which precisely?

Also, your commit doesn't contain a second body line (well, just add description there) and is missing a signed-off-by line, which indicates accepting Developer Certificate of Origin. Please add it using git commit --amend -s

dsseng avatar Oct 06 '24 09:10 dsseng

The NVME Part of the Dirver is disabled because it has Source Code related problems

Which precisely?

Also, your commit doesn't contain a second body line (well, just add description there) and is missing a signed-off-by line, which indicates accepting Developer Certificate of Origin. Please add it using git commit --amend -s

When trying to build with full NVME support, the build fails with the following error:

image

feniarus avatar Oct 08 '24 15:10 feniarus

This PR is for fixing the Mellanox OFED Driver Package and adding the missing Kernel Flags for it to build. The NVME Part of the Dirver is disabled because it has Source Code related problems.

Signed-off-by: Feniarus [email protected]

does this means it's better than the in-tree kernel mlx5 drivers, just trying to gauge if we need to build and maintain this? :thinking:

frezbo avatar Oct 15 '24 14:10 frezbo

also wants to know if this co-exist with in-tree kernel drivers, might need to denylist udev loading mlx5 by default I guess

frezbo avatar Oct 15 '24 14:10 frezbo