kres icon indicating copy to clipboard operation
kres copied to clipboard

feature: support running go-winres on Windows binaries for embedding manifest properties

Open brantgurga opened this issue 1 year ago • 6 comments

I got issues open with omni and talos to add manifest properties to the Windows executables. The primary place to change in my proof of concept is in the Dockerfile. Since that Dockerfile is generated by kres, the kres executable needs updated with the relevant lines. I already got a branch with a kres update that it did indeed output the desired lines, but I gotta refine it more. See also the issue for omnictl: https://github.com/siderolabs/omni/issues/666 See also the issue for talosctl: https://github.com/siderolabs/talos/issues/9429 See also https://github.com/siderolabs/omni/pull/667/commits for the omnictl POC which manually edits Dockerfile so far Draft change so far for kres for this: https://github.com/siderolabs/kres/pull/451

brantgurga avatar Oct 12 '24 05:10 brantgurga

Can you link all of this in one place please?

DmitriyMV avatar Oct 12 '24 23:10 DmitriyMV

@DmitriyMV updated the description with links to other related pieces.

brantgurga avatar Oct 13 '24 00:10 brantgurga

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jun 10 '25 02:06 github-actions[bot]

Still applicable.

brantgurga avatar Jun 10 '25 02:06 brantgurga