siderolabs
Adding multipath-tools extension
This PR adds a new extension for multipath-tools. This is needed in the environment I work in, and probably others as well.
I intend for this PR to be an open conversation about this feature. I tried to implement this in a way that aligns with Talos goals and philosophy, but if there is any feedback on this please let me know.
Where can I find the requirements for properly formatting my commit messages?
This PR is stale because it has been open 45 days with no activity.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
hello! I just wanted to bump this PR, multipath is required in our environment (because of HPE CSI driver) and I was wondering if this is a dead end or if there's some activity in the background.
We can look into this as long as there's a reliable way to test this in our CI, someone needs to provide steps to test this
@frezbo What kind of result are you expecting from such a test/is there examples eg how you are testing the iscsi extension?
@frezbo What kind of result are you expecting from such a test/is there examples eg how you are testing the iscsi extension?
https://github.com/siderolabs/talos/blob/70612c1f9fc9056e8a3669ff10a385c4e8e03350/internal/integration/k8s/longhorn.go#L128 we have a test for iscsi using longhorn
Okay so we could also probably use rook for the integration suite as it also supports multipath devices..
This PR is stale because it has been open 45 days with no activity.
Has anyone been working on this lately and would be willing to collaborate? We need this extension for the Trident CSI (NetApp) to work in iSCSI mode.
For anyone interested we've got a working build of a multipath extension which works in connection with the NetApp Trident CSI with ISCSI volumes. There is some cleanup needed and we'll probably add an additional extension and/or trident PR just for supporting binaries in that are needed by Trident. We'll also try to create tests for it so it may be merged here. Currently our fork only works for Trident, because we hardcode the multipath.conf, we'll try to get it into a ExtensionServiceConfig, but this probably also needs changes to Trident.
See: https://github.com/INSRapperswil/extensions/tree/slim-multipath
For anyone interested we've got a working build of a multipath extension which works in connection with the NetApp Trident CSI with ISCSI volumes. There is some cleanup needed and we'll probably add an additional extension and/or trident PR just for supporting binaries in that are needed by Trident. We'll also try to create tests for it so it may be merged here. Currently our fork only works for Trident, because we hardcode the multipath.conf, we'll try to get it into a ExtensionServiceConfig, but this probably also needs changes to Trident.
See: https://github.com/INSRapperswil/extensions/tree/slim-multipath
if you could do a PR to extensions as draft would be great