discovery-service icon indicating copy to clipboard operation
discovery-service copied to clipboard

refactor: move `state.State` to public package

Open utkuozdemir opened this issue 10 months ago • 3 comments

Export the state struct from the internal package into a public package. It is a dependency of the ClusterServer GRPC service - so to be able to import and use it, the state also needs to be exported.

utkuozdemir avatar Apr 02 '24 10:04 utkuozdemir

Does it make sense to export the entrypoint, i.e. cmd/main.go as a function in a package?

smira avatar May 28 '24 11:05 smira

Does it make sense to export the entrypoint, i.e. cmd/main.go as a function in a package?

Hm, maybe not exactly that, as lots of other things going on there, but probably exporting the code that builds the state + grpc server struct + storage as a single function could work.

utkuozdemir avatar May 28 '24 11:05 utkuozdemir

Does it make sense to export the entrypoint, i.e. cmd/main.go as a function in a package?

Hm, maybe not exactly that, as lots of other things going on there, but probably exporting the code that builds the state + grpc server struct + storage as a single function could work.

yeah, I mean exactly something like that

smira avatar May 28 '24 12:05 smira