conform icon indicating copy to clipboard operation
conform copied to clipboard

Run on multiple commits during a pull_request

Open priyasiddharth opened this issue 5 years ago • 5 comments

Hello,

I had conform as a github action but on a pull request/push with multiple commits - it only appears to run on the latest commit.

How can I make it run on every commit in the diff with the base branch?

This is my config action - https://github.com/seahorn/seahorn/blob/master/.github/workflows/conform.yml config - https://github.com/seahorn/seahorn/blob/master/.conform.yaml

thanks Siddharth

priyasiddharth avatar May 14 '20 00:05 priyasiddharth

hello, that is currently not possible, but i would be happy to accept a PR

andrewrynhard avatar May 14 '20 01:05 andrewrynhard

I will not have cycles to fix this as of now. I will atleast try to send an update to the README to mention this limitation.

priyasiddharth avatar May 14 '20 13:05 priyasiddharth

@priyasiddharth It seems multicommit support was added in this commit, however it is not really documented. https://github.com/siderolabs/conform/commit/9023e3a114677975577153025e69dcdeebf72034

janderssonse avatar Feb 22 '23 07:02 janderssonse

@priyasiddharth It seems multicommit support was added in this commit, however it is not really documented. 9023e3a

Any idea how to enable this in a Github Actions workflow? There's a ton of potential in this tool but the documentation is lacking to make that feasible.

JossWhittle avatar Mar 13 '23 20:03 JossWhittle

@JossWhittle I got it working in a GH workflow by doing this->. https://github.com/janderssonse/janderscripts/blob/main/.github/workflows/dco.yml. It runs on pr's only, and checks all commits on that pr against main branch, but skips if not on a pr. Also look at the .conform.yaml in the project for settings i used. Note: (The GH checkout action needs a special ref setting, otherwise it will only check the merge commit, there are a few issues about that on the GH action issue tracker for example https://github.com/actions/checkout/issues/881 ).

janderssonse avatar Apr 14 '23 04:04 janderssonse