sidebar.nvim icon indicating copy to clipboard operation
sidebar.nvim copied to clipboard
verified publisher icon sidebar-nvim

Big PR

Open romgrk opened this issue 3 years ago • 2 comments

I had some time to spare today and I ended up doing quite a few modifications to this plugin. I realize this is going to be a big PR, but it still contains substantial improvements so I'd feel bad to keep it for myself. I don't insist on it being merged, I will maintain the differences in my fork if it's too substantial.

The main changes are:

  • Support coc.nvim in the builtin diagnostics
  • Include text/hl groups manipulation functions (extracted from barbar
  • Use them to provide proper layout & truncation in loclist.lua. You can observe the result in the TODOs section of the screenshot
  • Add/fix/modify HL groups to allow for more customization

And I still plan to do some more work.

image

romgrk avatar Jul 11 '22 00:07 romgrk

thanks a lot for the PR. this looks very cool. I didn't have much time to review this yet, but I will try to get to it in a few days.

GustavoKatel avatar Jul 14 '22 11:07 GustavoKatel

No worries, take your time, I have a few repos I maintain myself, totally get the lack of time to review everything :| If you have questions about why things are done in a way, leave ? marks I'll comment on them. I've been using this PR for a week, no bug to report until now.

romgrk avatar Jul 14 '22 12:07 romgrk