siddontang

Results 120 comments of siddontang
trafficstars

I think the user will rarely use a WriteBatch cross multi-threads, maybe make it with no send, no sync?

Hi @zengqingfu1442 The compression type must be already supported in RocksDB, so you should first support this in RocksDB.

You just need to add them in https://github.com/pingcap/rust-rocksdb/blob/master/librocksdb_sys/crocksdb/crocksdb/c.h#L949 and https://github.com/pingcap/rust-rocksdb/blob/master/librocksdb_sys/src/lib.rs#L87 if RocksDB supports it.

you can build rocksdb dynamically, use your own rust-rocksdb in https://github.com/pingcap/tikv/blob/master/Cargo.toml#L78 then run `make release`.

TiKV only needs linking your RocksDB lib dynamically, it doesn't care the source. BTW, if you want to link your own RocksDB statically, you can update https://github.com/pingcap/rust-rocksdb/blob/master/librocksdb_sys/build.sh#L127

1. If you let TiKV link RocksDB dynamically, you should install on each node. 2. If you build RocksDB statically in TiKV, you don't need to do it.

/cc @BusyJay