mwn icon indicating copy to clipboard operation
mwn copied to clipboard

Published 20 hours ago • verified publisher icon siddharthvp

Update axios

Open jayktaylor opened this issue 1 year ago • 2 comments

Hey, I've been updating some dependencies across our projects and noticed that mwn still uses version ^0.25.0 of axios. The latest version for axios is 1.6.2. Several vulnerabilties have been fixed between 0.25.0 and 1.6.2, which makes it worthwhile to upgrade.

The latest version of axios is currently incompatible with mwn as-is, but may be fixed with some small code changes.

jayktaylor avatar Nov 17 '23 13:11 jayktaylor

axios-cookiejar-support probably needs to be updated as well. Looks like some of mwn's networking code (in core.ts) can be dropped as they're natively supported in axios now. Happy to review a PR.

siddharthvp avatar Nov 17 '23 16:11 siddharthvp

Yeah - it seems likely that's the case. I can try and find some time in the next week to have a look into it. mwn has been very helpful for some of our tools - thanks for the work on it.

jayktaylor avatar Nov 18 '23 21:11 jayktaylor