react-ui icon indicating copy to clipboard operation
react-ui copied to clipboard

Default styles fail accessibility contrast lighthouse rules

Open NateRadebaugh opened this issue 6 years ago • 3 comments

Out of the box (light theme), running Lighthouse audits, I'm not getting 100% in accessibility...

"Background and foreground colors do not have a sufficient contrast ratio."

image

NateRadebaugh avatar Apr 12 '20 16:04 NateRadebaugh

That's a great bug report! I'll look into it 👍

siddharthkp avatar Apr 12 '20 16:04 siddharthkp

Can we integrate some tool to check color contrasts during build or after build?

Something on these lines.

https://github.com/bbc/color-contrast-checker https://dev.to/alvaromontoro/building-your-own-color-contrast-checker-4j7o

ankibalyan avatar May 12 '20 12:05 ankibalyan

Can we integrate some tool to check color contrasts during build or after build?

When it comes to default themes, I wouldn't try to solve it with CI/build tooling. Assigned it to myself to work on the default colors

siddharthkp avatar May 12 '20 14:05 siddharthkp