github-build icon indicating copy to clipboard operation
github-build copied to clipboard

Published 20 hours ago • verified publisher icon siddharthkp

Support for Github enterprise URLs

Open rahulgandhi opened this issue 8 years ago • 4 comments

This PR fixes https://github.com/siddharthkp/github-build/issues/3 and also https://github.com/siddharthkp/bundlesize/issues/95.

I have tested it on my Github enterprise account.

Once we release this, I'll update github-build version on bundlesize

rahulgandhi avatar Aug 28 '17 07:08 rahulgandhi

I think it is failing because I don't have a key for the account the test is written for. The test depends on process.env.github_token which I don't have for this repo.

rahulgandhi avatar Aug 28 '17 07:08 rahulgandhi

@siddharthkp Can you have a look?

rahulgandhi avatar Aug 30 '17 12:08 rahulgandhi

@siddharthkp We gave this patch a try and it seems to be working. Any chances on getting this merged? If you need/want some updates let me know and we can work through it. Thanks!!!!

jmccann avatar Jun 06 '18 15:06 jmccann

I'm up for making any modifications to this PR if needed.

rahulgandhi avatar Jun 06 '18 16:06 rahulgandhi